Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more loud in case of error/exception on the native side #414

Merged
merged 7 commits into from
Oct 7, 2022

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Oct 5, 2022

This PR:

This should make users able to self-diagnose much more issues.

@bartekpacia bartekpacia changed the title Add timeouts to finding native views Throw error and log them if native view is not found Oct 6, 2022
@bartekpacia bartekpacia force-pushed the tweak/wait_for_native_views branch from cbb55f3 to 386b2d6 Compare October 6, 2022 08:40
@github-actions github-actions bot added the package: patrol Related to the patrol package (native automation, test bundling) label Oct 6, 2022
@bartekpacia bartekpacia force-pushed the tweak/wait_for_native_views branch 2 times, most recently from 9463d59 to 085e4ae Compare October 6, 2022 16:11
@bartekpacia bartekpacia force-pushed the tweak/wait_for_native_views branch from 085e4ae to 5452757 Compare October 6, 2022 16:15
@bartekpacia bartekpacia changed the title Throw error and log them if native view is not found Be more loud in case of error/exception on the native side Oct 6, 2022
@bartekpacia bartekpacia force-pushed the tweak/wait_for_native_views branch 5 times, most recently from c9c9758 to 9f37474 Compare October 6, 2022 17:00
@bartekpacia bartekpacia requested review from lewandowski-jan, shilangyu and Xezolpl and removed request for lewandowski-jan October 6, 2022 17:00
@bartekpacia bartekpacia marked this pull request as ready for review October 6, 2022 17:00
@bartekpacia bartekpacia force-pushed the tweak/wait_for_native_views branch 2 times, most recently from aabe6ea to 054c75a Compare October 6, 2022 17:01
@bartekpacia bartekpacia force-pushed the tweak/wait_for_native_views branch from 054c75a to 853d541 Compare October 6, 2022 19:04
@bartekpacia bartekpacia merged commit 92b91b2 into master Oct 7, 2022
@bartekpacia bartekpacia deleted the tweak/wait_for_native_views branch October 7, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging of errors when native view is not found on iOS
2 participants