Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android flavor to dartDefines. #2425

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

GChanathip
Copy link
Contributor

this PR fix issue #2256

Copy link

docs-page bot commented Nov 22, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/leancodepl/patrol~2425

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added the package: patrol_cli Related to the patrol_cli package label Nov 22, 2024
@piotruela piotruela self-assigned this Nov 25, 2024
Copy link
Collaborator

@piotruela piotruela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Overall lgtm, just a small nitpick.
Please also add an entry to changelog.

packages/patrol_cli/lib/src/crossplatform/app_options.dart Outdated Show resolved Hide resolved
@GChanathip GChanathip requested a review from piotruela November 26, 2024 05:21
@GChanathip GChanathip requested a review from piotruela November 26, 2024 08:26
Copy link
Collaborator

@piotruela piotruela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 🙌

@piotruela piotruela merged commit 77739b9 into leancodepl:master Nov 26, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: patrol_cli Related to the patrol_cli package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants