Code coverage #2294
Merged
Code coverage #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trol to not collect coverage from all tests if there were more than 1 tests per file
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
github-actions
bot
added
package: patrol
gogolon
requested review from
pdenert,
piotruela and
mateuszwojtczak
as code owners
bartekpacia
approved these changes
Aug 22, 2024
Comment on lines
+205
to
+213
| extension<T> on Completer<T> { | ||
| void disposedBy(DisposeScope disposeScope, T disposeValue) { | ||
| disposeScope.addDispose(() { | ||
| if (!isCompleted) { | ||
| complete(disposeValue); | ||
| } | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems like a good addition to package:dispose_scope by @RobertOdrowaz.
packages/patrol_cli/lib/src/coverage/device_to_host_port_transformer.dart
Outdated
Show resolved
Hide resolved
piotruela
reviewed
Aug 28, 2024
|
@gogolon good job! Please bump versions of patrol and patrol_cli, remember about |
pdenert
reviewed
Sep 11, 2024
| @@ -92,7 +92,7 @@ Future<void> main() async { | |||
| ); | |||
| testExplorationCompleter.complete(dartTestGroup); | |||
| print('patrol_test_explorer: obtained Dart-side test hierarchy:'); | |||
| printGroupStructure(dartTestGroup); | |||
| reportGroupStructure(dartTestGroup); | |||
There was a problem hiding this comment.
This probably force incompatibility with old patrol versions
pdenert
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a possibility to collect code coverage from patrol tests using
patrol test --coverage. Unwanted files can be ignored using glob patterns, i.e:patrol test --coverage --coverage-ignore="**/*.g.dart"The PR is not finished yet - there is one thing that needs to be addressed. Currently, the coverage is only collected from isolates that are running when particular test finishes - if an isolate exits prior to this, it will be omitted. The--pause-on-exitflag is already set, but coverage has to be collected from the paused isolate separately, and it has to be resumed (other isolates might be waiting for its result).The code should be now fully functional, but it needs some cleanup