Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows for running patrol tests on Android #2270

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Conversation

piotruela
Copy link
Collaborator

@piotruela piotruela commented Jul 18, 2024

As in the title. Also changed runner for ios tests to M1.

@piotruela piotruela force-pushed the fix-test-workflows branch from b8f12c2 to 2f2e143 Compare July 18, 2024 13:37
@piotruela piotruela changed the title Fix workflows for running patrol tests Fix workflows for running patrol tests on Android Jul 18, 2024
@piotruela piotruela marked this pull request as ready for review July 18, 2024 13:48
Copy link
Collaborator

@pdenert pdenert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotruela piotruela requested a review from fylyppo July 19, 2024 13:26
@fylyppo
Copy link
Collaborator

fylyppo commented Jul 19, 2024

I see that webview fails on Android, have you tried to fix that also? At the first sight it can fail because "login" button looks non-interactive during some time at the beginning. Easy fix would be to set some delay before tapping on that button.

@piotruela piotruela merged commit 608005f into master Jul 23, 2024
9 of 15 checks passed
@piotruela piotruela deleted the fix-test-workflows branch July 23, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants