-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflows for running patrol tests on Android #2270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotruela
force-pushed
the
fix-test-workflows
branch
from
July 18, 2024 13:37
b8f12c2
to
2f2e143
Compare
piotruela
changed the title
Fix workflows for running patrol tests
Fix workflows for running patrol tests on Android
Jul 18, 2024
pdenert
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fylyppo
reviewed
Jul 19, 2024
dev/e2e_app/integration_test/permissions/permissions_location_test.dart
Outdated
Show resolved
Hide resolved
fylyppo
reviewed
Jul 19, 2024
dev/e2e_app/integration_test/permissions/permissions_location_test.dart
Outdated
Show resolved
Hide resolved
fylyppo
reviewed
Jul 19, 2024
I see that webview fails on Android, have you tried to fix that also? At the first sight it can fail because "login" button looks non-interactive during some time at the beginning. Easy fix would be to set some delay before tapping on that button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title. Also changed runner for ios tests to M1.