Add support for physical iOS devices #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package: patrol_cli
|
This is WIP. Feel free to look around :) I'll tag you as reviewers once it's ready, @iasiu @shilangyu. |
bartekpacia
force-pushed
the
feature/ios
branch
from
966be92 to
bb638c8
Compare
bartekpacia
commented
Aug 11, 2022
bartekpacia
force-pushed
the
feature/ios
branch
5 times, most recently
from
dcb4e49 to
a79313b
Compare
shilangyu
reviewed
Aug 12, 2022
AutomatorServer/android/app/src/androidTest/java/pl/leancode/automatorserver/Logger.kt
Outdated
Show resolved
Hide resolved
AutomatorServer/ios/run_tests
Outdated
Comment on lines
12
to
14
| http GET localhost:8081/isRunning | ||
| http POST localhost:8081/openApp id='pl.baftek.discoverRudy' | ||
| http POST localhost:8081/pressHome || true |
There was a problem hiding this comment.
Also, what is http? Seems like a non-standard tool, if so, it should be somewhere mentioned as a external dependency probably
There was a problem hiding this comment.
It's HTTPie, basically a modern curl.
I added a comment to this script.
packages/maestro_cli/lib/src/features/drive/ios/ios_driver.dart
Outdated
Show resolved
Hide resolved
packages/maestro_cli/lib/src/features/drive/ios/ios_driver.dart
Outdated
Show resolved
Hide resolved
packages/maestro_cli/lib/src/features/drive/ios/ios_driver.dart
Outdated
Show resolved
Hide resolved
Comment on lines
+88
to
99
| // On iOS, "flutter" is not prefixed | ||
| final flutterPrefix = RegExp('flutter: '); | ||
|
|
||
| // On Android, "flutter" is prefixed with "I\" | ||
| final flutterWithPortPrefix = RegExp(r'I\/flutter \(\s*[0-9]+\): '); | ||
| if (line.startsWith(flutterWithPortPrefix)) { | ||
| log.info(line.replaceFirst(flutterWithPortPrefix, '')); | ||
| } else if (line.startsWith(flutterPrefix)) { | ||
| log.info(line.replaceFirst(flutterPrefix, '')); | ||
| } else { | ||
| log.fine(text); | ||
| log.fine(line); | ||
| } |
There was a problem hiding this comment.
All of these string matching will definitely be a source of bugs :(
There was a problem hiding this comment.
yeah :(
Any better ideas?
| } else { | ||
| p = _defaultArtifactPath; | ||
| } | ||
|
|
||
| return p; | ||
| } | ||
|
|
||
| String get _defaultArtifactPath => path.join(_homePath, '.maestro'); | ||
| String get _defaultArtifactPath => path.join(_homeDirPath, '.maestro'); |
There was a problem hiding this comment.
Thanks, I forgot about it. Fixed now.
This reverts commit 3687a6e.
bartekpacia
force-pushed
the
feature/ios
branch
from
5fa8875 to
9e276ec
Compare
shilangyu
reviewed
Aug 12, 2022
| deviceJson as Map<String, dynamic>; | ||
|
|
||
| final targetPlatform = deviceJson['targetPlatform'] as String; | ||
| if (targetPlatform != 'android-arm64' && targetPlatform != 'ios') { |
There was a problem hiding this comment.
What happens if someone wants to run it on android-x86? or any other architecture supported by android?
bartekpacia
force-pushed
the
feature/ios
branch
from
5c126e5 to
2a09862
Compare
|
Gonna merge to see how (bad) CI behaves. |
This was referenced Aug 14, 2022
bartekpacia
added a commit
that referenced
this pull request
Sep 15, 2022
* maestro_cli: list also physical iOS devices * print current IP address * maestro_cli: add temporary "simulator" flag to `maestro drive` * run on public interface * try to handle permission popups * remove commented-out code * refactor touching many areas of the codebase, so sad * fixes * make `iproxy` work * disable `swift-format` action * AutomatorServer/android: minor changes to match iOS server * create `run_tests` script * forward $MAESTRO_PORT to Swift * refactor android AutomatorServer a bit * maestro_cli: refactor ios_driver code * maestro_cli: more refactors * AutomatorServer/ios: fix error catching * AutomatorServer/ios: fix passing `TEST_RUNNER_MAESTRO_PORT` to Swift code * maestro_test: remove `package:logging` * refactor code handling artifacts, create ArtifactsRepository * big refactor + download iOS artifacts * maestro_cli: fix iOS artifacts extracting to a wrong place * fully implement `maestro_cli-publish` workflow for iOS * remove commented-out code in ServerLoop.swift * throw Exception when flutter_driver exits with code != 0 * add docs in `ios/run_tests` script * maestro_cli: change default artifact path to `$HOME/.cache/maestro`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP server library I used for iOS (Embassy) is way too buggy. I'll have to look for alternatives to replace it. It's probably this HTTP library that causes
SocketExceptions on the Dart side.