Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about not finishing #1762

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

tenhobi
Copy link
Contributor

@tenhobi tenhobi commented Oct 2, 2023

After trying Patrol for a while and not knowing why my tests do not finish when they couldn't find a widget to tap on, etc., I would appreciate a warning in docs for that! 🙏

Also related to #1602

@tenhobi tenhobi requested a review from bartekpacia as a code owner October 2, 2023 11:31
@github-actions github-actions bot added the docs Concerns doc comments, READMEs, or docs label Oct 2, 2023
@bartekpacia
Copy link
Contributor

Thanks for this PR @tenhobi!

Small thing: I'm not sure docs/patrol/finders is the right place for it. That section in the docs talks about Patrol finders, which can be used in both widget test and in integration tests. Not all Patrol users use custom finders, some are only interested in native automation, and then they likely wouldn't see this warning.

I think the better place for it would be the Getting Started guide. What you think?

@tenhobi
Copy link
Contributor Author

tenhobi commented Oct 2, 2023

I put it there because it's one of few places where timeouts are mentioned. I can move it to getting started section. :)

@tenhobi
Copy link
Contributor Author

tenhobi commented Oct 2, 2023

@bartekpacia I moved it to the section you suggested, is this better? ☺️

@bartekpacia
Copy link
Contributor

Yup, thanks!

@bartekpacia bartekpacia merged commit f02d4d7 into leancodepl:master Oct 2, 2023
1 of 3 checks passed
@tenhobi tenhobi deleted the patch-1 branch October 6, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Concerns doc comments, READMEs, or docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants