Add support for basic test lifecycle callbacks #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: patrol
bartekpacia
force-pushed
the
lifecycle_callbacks
branch
from
d01f81a to
c4d7e8f
Compare
github-actions
bot
removed
the
package: patrol_cli
bartekpacia
force-pushed
the
lifecycle_callbacks
branch
from
f549863 to
f238d82
Compare
So far so good - this is suspicious.
bartekpacia
force-pushed
the
lifecycle_callbacks
branch
from
115daa3 to
3ded673
Compare
bartekpacia
force-pushed
the
lifecycle_callbacks
branch
from
1e9fd9e to
1359386
Compare
|
The playground in |
bartekpacia
changed the title
…1-and-iOS12 Add support for ios11 and ios12
patrol: bump version to 2.4.0-dev.1
bartekpacia
force-pushed
the
develop
branch
2 times, most recently
from
1e08984 to
45701f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1503.
Possible concerns, defused
Problem:
PatrolBinding.ensureInitialized()adds asetUpand atearDown.Answer: Yes, but PatrolBinding is a singleton (like all bindings), and its initialization happens in the generated
test_bundle.dart.Problem: Reporting results back to the native side depends on
tearDownAnswer: Yes, but tearDown execute in the reverse order, so the first
tearDownthatPatrolBindingadds executes the last. This is what we want.Problem: What if an exception in thrown inside
setUportearDown?Answer: The subsequent setUps and the test won't be executed. TearDowns will be executed. A failure will be present in the native report.