Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from gRPC to HTTP #1681

Merged
merged 88 commits into from
Sep 15, 2023
Merged

Move from gRPC to HTTP #1681

merged 88 commits into from
Sep 15, 2023

Conversation

zltnDC
Copy link
Contributor

@zltnDC zltnDC commented Sep 11, 2023 •
edited
Loading

TODO:

  • request timeouts should be the same as test timeouts
  • Android - packagingOptions - is it possible to get rid of it ?
  • Android/example - throws PatrolAppServiceClientException - we should rather catch this error and not change the method.
  • grpc models had a pattern with hasProperty. What do we want to do with it ?
  • remove commented lines of code -> throw exception etc. - these lines helped in debugging corner cases

zltnDC added 30 commits August 11, 2023 15:44
@zltnDC
Add schema and empty package
f5af8ca
@zltnDC
Add schema definition, and resolveSchema function
9abecbb
@zltnDC
Add dart generator
8bcfe72
@zltnDC
Add simple swift message builder
a809e5e
@zltnDC
Extend schema
fce81a6
@zltnDC
Add NativeAutomator to schema
c1ba157
@zltnDC
Fix schema and dart generator
4b39776
@zltnDC
Add simple telegraph generator
051250f
@zltnDC
Add list support in schema
0913afb
@zltnDC
Add json_serializable to patrol. Add script to generate models from s…
3123f5d 
…chema
@zltnDC
Add type mapping to ios generator
64cdc96
@zltnDC
Add enums to ios output
25345b7
@zltnDC
Add telegraph dependency
c6c2bc8
@zltnDC
Comment PatrolAppService in contracts.proto
70161a9
@zltnDC
Add shelf server generator
ae36c7f
@zltnDC
Fix url path
5a4ec9d
@zltnDC
Migrate ios generator
11b6889
@zltnDC
Fix schema
26d0840
@zltnDC
Migrate swift PatrolAppServiceClient
4a0496a
@zltnDC
Print address details
ab4851f
@zltnDC
Improve shelf handler
f0359cd
@zltnDC
Add dart client generation
63f50a0
@zltnDC
Get rid of grpc on the dart side
fe25e8e
@zltnDC
Migrate telegraph generator api to new style
a2b671a
@zltnDC
Remove grpc, migrate to new contracts
9cc9c5d
@zltnDC
Generate telegraph routes and handlers
3ff0978
@zltnDC
Add telegraph server
8b71239
@zltnDC
Fix dart deserialization
ad55462
@zltnDC
Fix app crash when using dark mode on iOS simulators
f9d4f6f
@zltnDC
Change Swift client address
aedf943
@zltnDC zltnDC marked this pull request as ready for review September 14, 2023 12:24
@zltnDC zltnDC requested a review from bartekpacia as a code owner September 14, 2023 12:24
bartekpacia
bartekpacia reviewed Sep 14, 2023
View reviewed changes
gen_from_schema Outdated Show resolved Hide resolved
bartekpacia
bartekpacia reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's it for now

will come back to it later

packages/patrol/android/build.gradle Outdated Show resolved Hide resolved
packages/patrol/android/src/main/kotlin/pl/leancode/patrol/Automator.kt Outdated Show resolved Hide resolved
packages/patrol/android/src/main/kotlin/pl/leancode/patrol/Automator.kt Outdated Show resolved Hide resolved
packages/patrol/android/src/main/kotlin/pl/leancode/patrol/Automator.kt Outdated Show resolved Hide resolved
packages/patrol/android/src/main/kotlin/pl/leancode/patrol/AutomatorServer.kt Outdated Show resolved Hide resolved
packages/patrol/ios/Classes/AutomatorServer/Contracts.swift Show resolved Hide resolved
packages/patrol/ios/Classes/AutomatorServer/Contracts.swift Outdated Show resolved Hide resolved
packages/patrol/ios/Classes/ObjCPatrolAppServiceClient.swift Outdated Show resolved Hide resolved
packages/patrol/ios/Classes/ObjCPatrolAppServiceClient.swift Outdated Show resolved Hide resolved
packages/patrol/pubspec.yaml Outdated Show resolved Hide resolved
@zltnDC zltnDC requested a review from shilangyu September 14, 2023 13:37
@bartekpacia
Copy link
Contributor

bartekpacia commented Sep 14, 2023 •
edited
Loading

I'm worried that patrol_gen has no tests.

but I also suspect the need for changes will be near-zero

bartekpacia
bartekpacia reviewed Sep 14, 2023
View reviewed changes
schema.dart
Comment on lines +43 to +56
class Selector {
String? text;
String? textStartsWith;
String? textContains;
String? className;
String? contentDescription;
String? contentDescriptionStartsWith;
String? contentDescriptionContains;
String? resourceId;
int? instance;
bool? enabled;
bool? focused;
String? pkg;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does patrol_gen support copying doc comments from Dart into Swift and Kotlin?

We plan to add docs to the Selector and NativeView classes, so we need thsi feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can easily add this functionality later. I also think exporting internal models is not a best practice.

@bartekpacia bartekpacia mentioned this pull request Sep 15, 2023
Merged
bartekpacia
bartekpacia approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@bartekpacia bartekpacia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also merge with master to get CI to run. it stopped running after base branch was changed to develop. See #1696

@zltnDC zltnDC merged commit 3950c72 into develop Sep 15, 2023
27 of 29 checks passed
@zltnDC zltnDC deleted the feature/stop-depending-on-gRPC-code-generator branch September 15, 2023 10:58
@bartekpacia bartekpacia mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia approved these changes

@mateuszwojtczak mateuszwojtczak Awaiting requested review from mateuszwojtczak

@shilangyu shilangyu Awaiting requested review from shilangyu

Assignees
No one assigned
Labels
package: patrol_cli Related to the patrol_cli package package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zltnDC @shilangyu @bartekpacia