Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Dart-side group()s #1634

Merged
merged 39 commits into from
Sep 13, 2023
Merged

Add support for Dart-side group()s #1634

merged 39 commits into from
Sep 13, 2023

Conversation

bartekpacia
Copy link
Contributor

This PR resolves #1619.

@bartekpacia bartekpacia marked this pull request as draft August 14, 2023 09:58
@github-actions github-actions bot added package: patrol Related to the patrol package (native automation, test bundling) package: patrol_cli Related to the patrol_cli package labels Aug 14, 2023
@leancodepl leancodepl deleted a comment from docs-page bot Aug 14, 2023
@bartekpacia
Copy link
Contributor Author

Hot Restart status: works, but per-file, instead of per-test().

@bartekpacia bartekpacia force-pushed the feature/dart_side_groups branch from 56be5b0 to 31592ea Compare August 14, 2023 11:03
@bartekpacia bartekpacia force-pushed the feature/dart_side_groups branch from c74539b to 2cf225a Compare August 15, 2023 13:09
@mkhtradm01
Copy link

mkhtradm01 commented Sep 6, 2023 •
edited
Loading

We really need this feature at the moment, when we use group() the test finishes but doesn't complete, it just hangs, looking forward to have it released 🙌

@mkhtradm01 mkhtradm01 mentioned this pull request Sep 6, 2023
Closed
@bartekpacia bartekpacia force-pushed the feature/dart_side_groups branch from 88282b9 to 1b44a73 Compare September 12, 2023 10:16
@bartekpacia bartekpacia force-pushed the feature/dart_side_groups branch from fb33e4a to a53e42a Compare September 12, 2023 10:23
@bartekpacia bartekpacia force-pushed the feature/dart_side_groups branch from ddc3b8a to a2db518 Compare September 12, 2023 13:00
@bartekpacia bartekpacia marked this pull request as ready for review September 12, 2023 13:01
@bartekpacia bartekpacia changed the base branch from master to develop September 12, 2023 13:01
@bartekpacia bartekpacia changed the base branch from develop to master September 12, 2023 13:02
@bartekpacia bartekpacia mentioned this pull request Sep 13, 2023
Open
@bartekpacia bartekpacia changed the base branch from master to develop September 13, 2023 09:50
@bartekpacia bartekpacia merged commit fd79cc3 into develop Sep 13, 2023
25 of 29 checks passed
@bartekpacia bartekpacia deleted the feature/dart_side_groups branch September 13, 2023 09:51
@bartekpacia
Copy link
Contributor Author

@mkhtradm01 Check out new dev releases, group()s should work there.

@mkhtradm01
Copy link

@bartekpacia Thank you 🙌

@bartekpacia bartekpacia mentioned this pull request Sep 19, 2023
Open
@ghost
Copy link

ghost commented Sep 27, 2023

@bartekpacia can you elaborate on how exactly group() should work with latest dev versions of Patrol (2.3.0-dev.4) & patrol_cli (2.2.0-dev.2)? Can it be group() with multiple patrolTest() inside in one file? Because currently if I run "old style" (one patrolTest() per file) or if I run "new" (group() with 2 patrolTest() inside in one file) the result is the same - 1st test passed and run finished w/o launching 2nd one. Terminal shows failure, but html report shows that one (1st) test passed and that's it. TY in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilangyu shilangyu shilangyu approved these changes

@zltnDC zltnDC Awaiting requested review from zltnDC

Assignees
No one assigned
Labels
package: patrol_cli Related to the patrol_cli package package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Dart-side group()s and multiple test()s
3 participants
@bartekpacia @mkhtradm01 @shilangyu