Bring back Hot Restart #1286
Merged
Bring back Hot Restart #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekpacia
requested review from
shilangyu,
mateuszwojtczak,
fylyppo and
jBorkowska
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
github-actions
bot
added
package: patrol
shilangyu
approved these changes
May 19, 2023
fylyppo
approved these changes
May 19, 2023
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back Hot Restart. See also #1004.
I went the easiest (and most sensible, IMO) way about this – the
test_bundle.dartis not generated at all when usingpatrol develop. In other words, no test bundling is used. This isn't a problem sincepatrol developaccepts only a single--target.What bugs me a lot is that we have absolutely no tests for Hot Restart. I'm also not sure how we could write them. Something to keep in mind.