Skip to content

Commit

Permalink
adapt code to new dependencies versions
Browse files Browse the repository at this point in the history
  • Loading branch information
bartekpacia committed Nov 14, 2023
1 parent e64676b commit 66c83c6
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 13 deletions.
6 changes: 5 additions & 1 deletion packages/patrol_cli/lib/src/base/logger.dart
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ class Logger extends mason_logger.Logger {
}

@override
void warn(String? message, {String tag = ''}) {
void warn(
String? message, {
String tag = 'WARN',
mason_logger.LogStyle? style,
}) {
super.warn(message, tag: tag);
}
}
4 changes: 0 additions & 4 deletions packages/patrol_cli/lib/src/commands/develop.dart
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ class DevelopCommand extends PatrolCommand {
switch (device.targetPlatform) {
case TargetPlatform.android:
buildAction = () => _androidTestBackend.build(androidOpts);
break;
case TargetPlatform.iOS:
buildAction = () => _iosTestBackend.build(iosOpts);
}
Expand Down Expand Up @@ -235,7 +234,6 @@ class DevelopCommand extends PatrolCommand {
if (packageName != null) {
action = () => _androidTestBackend.uninstall(packageName, device);
}
break;
case TargetPlatform.iOS:
final bundleId = iosOpts.bundleId;
if (bundleId != null) {
Expand All @@ -245,7 +243,6 @@ class DevelopCommand extends PatrolCommand {
device: device,
);
}
break;
}

try {
Expand Down Expand Up @@ -276,7 +273,6 @@ class DevelopCommand extends PatrolCommand {
if (package != null && uninstall) {
finalizer = () => _androidTestBackend.uninstall(package, device);
}
break;
case TargetPlatform.iOS:
appId = iosOpts.bundleId;
action = () async =>
Expand Down
5 changes: 0 additions & 5 deletions packages/patrol_cli/lib/src/commands/test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ See https://github.com/leancodepl/patrol/issues/1316 to learn more.
if (packageName != null) {
action = () => _androidTestBackend.uninstall(packageName, device);
}
break;
case TargetPlatform.iOS:
final bundleId = iosOpts.bundleId;
if (bundleId != null) {
Expand All @@ -206,7 +205,6 @@ See https://github.com/leancodepl/patrol/issues/1316 to learn more.
device: device,
);
}
break;
}

try {
Expand All @@ -225,7 +223,6 @@ See https://github.com/leancodepl/patrol/issues/1316 to learn more.
switch (device.targetPlatform) {
case TargetPlatform.android:
buildAction = () => _androidTestBackend.build(androidOpts);
break;
case TargetPlatform.iOS:
buildAction = () => _iosTestBackend.build(iosOpts);
}
Expand Down Expand Up @@ -258,7 +255,6 @@ See https://github.com/leancodepl/patrol/issues/1316 to learn more.
if (package != null && uninstall) {
finalizer = () => _androidTestBackend.uninstall(package, device);
}
break;
case TargetPlatform.iOS:
action = () async => _iosTestBackend.execute(iosOpts, device);
final bundleId = iosOpts.bundleId;
Expand All @@ -269,7 +265,6 @@ See https://github.com/leancodepl/patrol/issues/1316 to learn more.
device: device,
);
}
break;
}

var allPassed = true;
Expand Down
2 changes: 0 additions & 2 deletions packages/patrol_cli/lib/src/crossplatform/flutter_tool.dart
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,8 @@ class FlutterTool {
switch (_platform.operatingSystem) {
case Platform.macOS:
process = await _processManager.start(['open', url]);
break;
case Platform.windows:
process = await _processManager.start(['start', url]);
break;
case Platform.linux:
process = await _processManager.start(['xdg-open', url]);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/patrol_cli/test/ios/ios_test_backend_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -217,5 +217,5 @@ class FakeProcessManager extends Fake implements ProcessManager {}

class FakeLogger extends Fake implements Logger {
@override
void detail(String? message) {}
void detail(String? message, {String? Function(String?)? style}) {}
}

0 comments on commit 66c83c6

Please sign in to comment.