Skip to content

Commit

Permalink
Revert "DartGroupEntry: add encodedFullName field"
Browse files Browse the repository at this point in the history
This reverts commit 43eb88f.
  • Loading branch information
bartekpacia committed Sep 11, 2023
1 parent 43eb88f commit 5aeb6e1
Show file tree
Hide file tree
Showing 9 changed files with 170 additions and 304 deletions.
1 change: 0 additions & 1 deletion .github/workflows/patrol-prepare.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ jobs:
- name: Run unit tests
working-directory: packages/patrol/example/ios
run: |
brew install xcbeautify
set -o pipefail && xcodebuild test \
-workspace Runner.xcworkspace \
-scheme Runner \
Expand Down
5 changes: 2 additions & 3 deletions contracts.proto
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ message ListDartTestsResponse {
message DartGroupEntry {
string name = 1;
string fullName = 2;
string encodedFullName = 3;
GroupEntryType type = 4;
repeated DartGroupEntry entries = 5;
GroupEntryType type = 3;
repeated DartGroupEntry entries = 4;

enum GroupEntryType {
GROUP = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public Object[] listDartTests() {
List<DartGroupEntry> dartTestCases = ContractsExtensionsKt.listTestsFlat(dartTestGroup, "");
List<String> dartTestCaseNamesList = new ArrayList<>();
for (DartGroupEntry dartTestCase : dartTestCases) {
dartTestCaseNamesList.add(dartTestCase.getFullName());
dartTestCaseNamesList.add(dartTestCase.getName());
}
Object[] dartTestCaseNames = dartTestCaseNamesList.toArray();
Logger.INSTANCE.i(TAG + "Got Dart tests: " + Arrays.toString(dartTestCaseNames));
Expand Down
Loading

0 comments on commit 5aeb6e1

Please sign in to comment.