Skip to content

Commit

Permalink
Fix naming of NativeView properties in the extension UI
Browse files Browse the repository at this point in the history
  • Loading branch information
mateuszwojtczak authored and bartekpacia committed Nov 13, 2023
1 parent 2019974 commit 08a11b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions packages/patrol_devtools_extension/lib/api/contracts.dart
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,9 @@ class NativeView with EquatableMixin {
final bool focused;
final bool enabled;
final int? childCount;
//TODO: rename to "resourceId" for consistency
final String? resourceName;
//TODO: rename to "pkg" for consistency
final String? applicationPackage;
final List<NativeView> children;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@ class _NodeDetails extends HookWidget {

final view = node.nativeView;
final rows = [
_KeyValueItem('applicationPackage:', view.applicationPackage),
_KeyValueItem('pkg:', view.applicationPackage),
_KeyValueItem('childCount:', view.childCount),
_KeyValueItem('className:', view.className),
_KeyValueItem('contentDescription:', view.contentDescription),
_KeyValueItem('enabled:', view.enabled),
_KeyValueItem('focused:', view.focused),
_KeyValueItem('resourceName:', view.resourceName),
_KeyValueItem('resourceId:', view.resourceName),
_KeyValueItem('text:', view.text),
];

Expand Down

0 comments on commit 08a11b6

Please sign in to comment.