Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency on provider #36

Merged
merged 2 commits into from
Oct 29, 2024
+6 −4
Merged

Remove direct dependency on provider #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
275f5df
Remove direct dependency on `provider`
n-bernat Oct 29, 2024
62379dc
Bump version & update changelog
n-bernat Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/bloc_presentation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.0.1

- Removed dependency on `provider`.

# 1.0.0

- **BREAKING**: Removed `useBlocPresentationListener` hook. Use `useOnStreamChanged` from `flutter_hooks` instead.
Expand Down
3 changes: 1 addition & 2 deletions packages/bloc_presentation/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: bloc_presentation
description: >
Extends blocs with an additional stream which can serve as a way of indicating
single-time events (so-called "presentation events").
version: 1.0.0
version: 1.0.1
homepage: https://github.com/leancodepl/bloc_presentation/tree/master/packages/bloc_presentation

environment:
Expand All @@ -14,7 +14,6 @@ dependencies:
sdk: flutter
flutter_bloc: ^8.0.0
nested: ^1.0.0
provider: ^6.0.1

dev_dependencies:
flutter_test:
Expand Down
3 changes: 1 addition & 2 deletions packages/bloc_presentation/test/bloc_presentation_listener_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import 'package:flutter/material.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mocktail/mocktail.dart';
import 'package:provider/provider.dart';

import 'fakes.dart';

Expand Down Expand Up @@ -60,7 +59,7 @@ void main() {

testWidgets('Correctly fallsback to the Provider cubit', (tester) async {
await tester.pumpWidget(
Provider<_TestCubit>.value(
BlocProvider<_TestCubit>.value(
value: cubit,
child: BlocPresentationListener<_TestCubit, _PresentationEvent>(
listener: listener,
Expand Down
Loading