Warning fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are defined already on some systems (for example, as std::min and std::max in C++), which was causing compilation of CppDemo to fail. Move min() and max() to the APG namespace so as to not trample on the global namespace.
These files are generated by the build system; having them in git just means pointless git churn every time someone builds with a different version of autotools.
This fixes a compiler warning with -Wnarrowing. Changing the type of the entire array is fine, since all users of the ulData arrays convert them to another type first.
|
Thanks for your observations on this and your suggested fixes. It's been a couple of years since I've done any C work of any kind. I'm pretty rusty with it and in the middle of other things at the moment. It may be a while but eventually I'll get my C environment up and running again and check this out on my system and fix or merge. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler warning fixes from compiling on Fedora 25 (automake 1.15, gcc 6.2.1).