Add CPF std name to MPAS-A registry #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new attribute to a number of variables within the core_atmosphere/Registry.xml file; cpf_std_name. It adds this attribute to variables that will be used in SIMA's CPF YSU Scheme.
|
The last PR was closed because I had a syntax error in the XML. Turns out a simple XML syntax error will cause strange errors in the MPAS Registry validation. So note to self (and others editing the Registry) to run your changes through an external XML syntax checker! |
ldfowler58
pushed a commit
that referenced
this pull request
Jul 19, 2020
Merge recent changes to MPAS-Model so that there are no conflicts in the code bases. These updates ensure that as MPAS-Model in JEDI moves toward using CMake that the two code bases are consistent. See corresponding [PR](https://github.com/JCSDA/mpas-jedi/pull/164) in JCSDA/mpas-jedi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new attribute to a number of variables within the
core_atmosphere/Registry.xml file; cpf_std_name. It adds this attribute to
variables that will be used in SIMA's CPF YSU Scheme.
@ldfowler58, @davegill, this commit will be followed up by changes to the MPAS Registry Parser that will generate common physics framework code, including the meta.module file.
I am putting the finishing touches on those changes, and I will have it ready in the next few days or so.