-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev dependencies to support python 3.11 #125
Conversation
Interesting mypy is failing here. I specifically ran pytest will multiple versions, but not mypy. I'll take a looking into why mypy would fail here. |
Alright, there have been changes to Starlette that was causing the mypy errors. I made updates to get mypy passing, but if you would like anything different I'm happy to make updates. |
|
🤦 I forgot to remove those imports after making the updates. I looked through CI to check for any other tests that will run, and looks like black is the only other one. I ran that locally with no errors so we should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@laurentS @sanders41 - Can we get this merged in and going? |
I believe it is ready to merge, but @laurentS if there is something else you want me to do just let me know. |
Done! Sorry, I assumed you were going to merge yourself after my previous comment, but I guess you're not actually allowed to do that! |
@sanders41 thank you for your contribution! As per #58 I've sent you an invite to join the repo. |
Thanks @laurentS, invite accepted |
Legit. Thanks all. |
@laurentS - What is your build process for getting this published? Looking to get this leveraged for 3.11 as I am starting an new project here shortly. |
@laurentS - I am not seeing this published. |
Hi @smittysmee this is not my day job, it's 100% volunteer work, so priority may fall behind. The process for publishing an update is a bit manual still. If you want to give a hand with opening a PR to prepare for a release 0.1.8, I think a lot of people will be grateful. Examples from past releases #120 or #108. As a policy (see #58 ), I add any contributor who's had at least one PR merged to the repo, to help reduce bottlenecks. You're welcome to join the team! |
Add me to the team, I would love to help where I may. If I get time tonight, I will do this as well. (Same boat as you) |
Closes #119