This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Feature: add days and weeks support to human duration #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected and clarified the 'MISSING RENDER' error case.
When passed as inline parameters, memory is expressed as MB. However, when passed in a config file, memory was expressed as KB. This created confusion https://discordapp.com/channels/253355867938750485/301912419368697856/541719192252973066 https://discordapp.com/channels/253355867938750485/301912419368697856/541719244094701597 https://discordapp.com/channels/253355867938750485/301912419368697856/541719343684124696
Make config file loader take ram in MB for consistency
clarification of error message
Fix Ant Build
… allow by scheduler depending on the past error, current settings (ram, cpu, gpu,...)
Fix grammar and consistency of README
… anymore, it should be removed
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
8d11595 to
5a333fd
Compare
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
5a333fd to
5df4268
Compare
…louet#246) * Feature: minimize to SysTray on the settings screen
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
5df4268 to
3e8fc06
Compare
…TPUT (laurent-clouet#252) As the value of the askForRendererKill flag is set right after the return of the kill process, under some particular memory and system load circumstances, a race condition occurs and the rendering process in the main thread is closed faster than the process.destroy() returns the control to the thread the called the OS.getOS().kill(process.getProcess()) method. If that condition occurs, the isAskForRendererKill() check returns false (the flag hasn't been set to True in the separate thread) and the execution continues with the frame output check (that doesn't exist as the rendering process was interrupted). The final outcome is a wrong NO_FILE_OUTPUT error instead of the proper RENDERER_KILLED_BY_USER_OVER_TIME. The fix has been setting the askForRendererKill flag to true before the process is destroyed. If the racing condition occurs, the askForRendererKill will be correctly set.
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
3e8fc06 to
b79f5de
Compare
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
b79f5de to
b94081c
Compare
The text UI gets quite messy during the render process, as it takes at least one extra line of the screen per second. This PR fixes that issue and also shows an ASCII bar to show the render progress.
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
b94081c to
133155e
Compare
…et#256) * Fix: -renderbucket-size option not applied if configuration file doesn't exist
luguina
force-pushed
the
improvement/add-days-to-human-date
branch
from
133155e to
ae547fc
Compare
laurent-clouet
force-pushed
the
master
branch
2 times, most recently
from
90c3325 to
7f1949e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some counters (ie the Session duration) can run for more than 24h. The existing method has a maximum resolution of hours, generating values like "175h 39m 4s". While is not an error, is not visually aesthetic.
The PR extends the maximum resolution to weeks, producing values like "3weeks 4days 6h 45m 9s" instead of "606h 45m 9s".