specify deps in useEffect and use useCallback for pushEvent #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid running calling the effect function on every rerender deps need to be specified. Makes sense to mark
liveState
as one.To avoid creating new
pushEvent
function on each rerender (and potentially cause unneeded rerenders if it is used as a prop or as a dep)useCallback
can be used.Specify type of
event
argument as a string inpushEvent
.Also looking at published filed seems that
build
folder is missing but there areuseLiveState.ts
andtsconfig.json
. I think it makes sense to addfiles
field topackage.json
to prevent exposing unnecessary files.