forked from phoenixframework/phoenix_live_view
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch upstream #1
Open
superchris
wants to merge
846
commits into
launchscout:master
Choose a base branch
from
phoenixframework:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't set href to # with non-get methods * Clean up strings in test
* Add intersperse component
`intersperse/1` was missing `@doc type: :component`, so it's showing up under the `Funtions` section instead of `Components`.
…g` with other loading states (#2263) * Include note about `phx-page-loading` near form *-loading docs * Use <.link> instead of live_patch/redirect in js-interop guide.
Co-authored-by: Rick Littel <[email protected]> Co-authored-by: José Valim <[email protected]>
Closes #2469.
This commit moves the logic that identifies the HTML tags, LV components, slots to Tokenizer.
This PR allows the Tokenizer to receive a custom tag handler. By default (used by Phoenix Live View templates) it uses Phoenix.Live.HTMLEngine but in case you want to use a different template, now you can implement your own Engine that implements `Phoenix.LiveView.TagEngine` callbacks. --------- Co-authored-by: José Valim <[email protected]>
Remove an unused/non-existing module from html_engine_test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.