-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add svelte example project and improving SDK docs #722
Open
nosnibor89
wants to merge
21
commits into
launchdarkly:main
Choose a base branch
from
nosnibor89:feat/svelte-sdk-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intial refactor to use new "@launchdarkly/js-client-sdk"
…improve initialization logic
[refactor] Update SvelteLDClient to use proxy for flag variations. Allows to track flag evaluations
…js-core into feat/svelte-sdk
…ization with user context
…ents refactor: update SvelteLDClient to use compat SDK and improve initial…
…e error handling in example
nosnibor89
changed the title
Feat/svelte sdk example
feat: add svelte example project and improving SDK docs
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
No issue.
Describe the solution you've provided
This pull request introduces a new Svelte example project to demonstrate the usage of
@launchdarkly/svelte-client-sdk
. The README of the example project includes steps to run such application that internally uses the SDK to interact with a boolean flag.Also, this PR adds documentation for
@launchdarkly/svelte-client-sdk
itself with a "Getting Started" session along with more advanced use of the SDK's api.Describe alternatives you've considered
I don't know what to write here.
Additional context
This is a follow up PR for #632. Where Svelte SDK was introduced.
After this, follow up PR for technical debt(upgrade Svelte 5 and improving test coverage ) should be expected