Extend firstaid for cleveref for gh1560 #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankMittelbach
approved these changes
Nov 24, 2024
| % \begin{macrocode} | ||
| \newif\iftag@ |
There was a problem hiding this comment.
I'm surprised that \newif doesn't bark, when the conditional aready exists, but it looks like that in fact the case. Not sure how god that is, but then it must have been that way forever.
There was a problem hiding this comment.
Yes, it comes from plain and plain doesn't check anything :)
| @@ -1,3 +1,7 @@ | |||
| 2024-11-24 Ulrike Fischer <[email protected]> | |||
|
|
|||
| * latex2e-first-aid-for-external-files.dtx: add iftag@-test to cleveref firstaid for issue #1560 | |||
There was a problem hiding this comment.
add \iftag@ test ...
(but not important)
josephwright
approved these changes
Nov 25, 2024
josephwright
added a commit
that referenced
this pull request
Nov 25, 2024
* add cleveref firstaid for issue #1560 * update hook tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated