Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagging/gh767 #1561

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Tagging/gh767 #1561

merged 12 commits into from
Nov 25, 2024

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • [n/a] ltnewsX.tex (and/or latexchanges.tex) updated

u-fischer
u-fischer approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@u-fischer u-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the blockblock it looks good imho.

required/latex-lab/latex-lab-block.dtx Outdated Show resolved Hide resolved
muzimuzhi
muzimuzhi reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@muzimuzhi muzimuzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra underscore in \l_@@__parindent_dim.

required/latex-lab/latex-lab-block.dtx Outdated Show resolved Hide resolved
required/latex-lab/latex-lab-block.dtx Outdated Show resolved Hide resolved
required/latex-lab/latex-lab-block.dtx Outdated Show resolved Hide resolved
@mbertucci47 mbertucci47 mentioned this pull request Nov 25, 2024
Open
@FrankMittelbach FrankMittelbach merged commit 661e70f into develop Nov 25, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzimuzhi muzimuzhi muzimuzhi left review comments

@u-fischer u-fischer u-fischer approved these changes

@josephwright josephwright Awaiting requested review from josephwright

@davidcarlisle davidcarlisle Awaiting requested review from davidcarlisle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankMittelbach @u-fischer @muzimuzhi