-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making the rotating package tagging compatible #1537
base: develop
Are you sure you want to change the base?
Conversation
% \changes{v2.16e}{2024/11/01}{correct tagging of the minipage} | ||
% \begin{macrocode} | ||
\begin{lrbox}\rot@float@box | ||
\SuspendTagging{\minipage}% | ||
\begin{minipage}\textheight | ||
\ResumeTagging{\minipage}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can guess what happens here, but from the outside the suspensions look odd. I wonder if that case happens elsewhere too and should get some sort of an interface, or at least perhaps a sentence or two explaining what goes on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add a sentence, but I have no idea for a better interface. One doesn't want the tagging from the minipage environment and imho this can only be done either by surrounding the minipage with such a code, or by defining a dedicated environment minipagewithouttagging
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the question to ask is under which circumstances do you not want minipage tagging? Because of it being inside an lrbox/mbox? What should happen if you have an lrbox with 2 minipages inside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
point is use of lrbox is core LaTeX so the combination with minipage should work. without the need to disable and reanable tagging by the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want the minipage tag (the Div) because I'm in a float and this minipage has no semantic meaning. I do not want the \tagmcend\tagstructend before the minipage (which normally closes a P-tag) and the reopening after the minipage as the minipage is in a lrbox and fills it up. Two minipages (without other material) should probably use a Div around them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
point is use of lrbox is core LaTeX so the combination with minipage should work. without the need to disable and reanable tagging by the user
Well the problem is that xxx minipage yyy
in a lrbox needs different tagging to minipage
alone. (At least with pdflatex which has to insert correctly nested MC-literals.)
Resolves issues latex3/tagging-project#751 and latex3/tagging-project#112
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updated