Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to get all supported algorithms #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add function to get all supported algorithms #30

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Oct 18, 2016

Adds get_supported_algorithms().

Signed-off-by: Christian Heimes [email protected]

npmccallum
npmccallum reviewed Oct 19, 2016
View reviewed changes
Copy link
Contributor

@npmccallum npmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we avoid using a function for this? This seems like a tuple to me, not a function.
  2. Let's split this up into multiple lists. For example: jose.jwe.crypters, jose.jwe.wrappers, etc.

@tiran
Copy link
Member Author

tiran commented Oct 21, 2016

Is the list really a static? The list of available algorithms might chance after _jose has been imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npmccallum npmccallum npmccallum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiran @npmccallum