Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix macOS CI #476

Merged
merged 1 commit into from
Nov 25, 2024
Merged

ci: Fix macOS CI #476

merged 1 commit into from
Nov 25, 2024

Conversation

neverpanic
Copy link
Collaborator

@neverpanic neverpanic commented Nov 25, 2024

Description

It seems Homebrew switched to the pkgconf implementation, but this causes a brew link step to fail.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@neverpanic neverpanic marked this pull request as draft November 25, 2024 09:37
It seems Homebrew switched to the pkgconf implementation but the GitHub
images ship with pkgconfig already, which causes an automatic brew link
step to fail.

Signed-off-by: Clemens Lang <[email protected]>
@neverpanic neverpanic changed the title ci: Use pkgconf to provide pkg-config on macOS ci: Fix macOS CI Nov 25, 2024
@neverpanic neverpanic marked this pull request as ready for review November 25, 2024 14:36
@neverpanic neverpanic requested a review from simo5 November 25, 2024 14:36
@simo5
Copy link
Member

simo5 commented Nov 25, 2024

Ok let me merge this one kroptic#121 first so we get a green on the Kryoptic tests too and then I'll merge this PR.

@simo5 simo5 merged commit 6dca0e0 into latchset:main Nov 25, 2024
37 checks passed
Jakuje added a commit to Jakuje/OpenSC that referenced this pull request Nov 26, 2024
Seem like the pkg-config is already installed on the github images

inspired by latchset/pkcs11-provider#476
frankmorgner pushed a commit to OpenSC/OpenSC that referenced this pull request Nov 26, 2024
Seem like the pkg-config is already installed on the github images

inspired by latchset/pkcs11-provider#476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants