Make sqlite database upgradabale and crypto-agile #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
verformat
branch
4 times, most recently
from
0e38432 to
d4bd38e
Compare
Jakuje
reviewed
Dec 10, 2024
simo5
force-pushed
the
verformat
branch
5 times, most recently
from
077482a to
f848663
Compare
Jakuje
approved these changes
Dec 11, 2024
Yes I always make a run with pkcs11-provider locally to ensure changes actually work in a backwards compatible way. |
Adds a new metadat table named meta. Sets a database version in this table to allow for future upgrades/backwards compatibility functions. Moves token info from a fake object to metadata storage. Signed-off-by: Simo Sorce <[email protected]>
The database Encryption Key is now stored as the ASN.1 Encoding of the KProtectedData structure, which contains all the data to reversibly derive t Key Encryption Key from the pin using PBKDF2 and then encrypt the Encryption Key with this KEK using AES GCM. This structure allows us to be crypto agile, as the derivation function and the encryption function are identified by the OIDs stored in this ASN.1 Structure, and therefore the data is fully self described so that a future change can be done while maintaining the ability to interoperate with pre-existing databases. Signed-off-by: Simo Sorce <[email protected]>
Implement the data encryption layer explained in the document added in the previoud commit. Specifically make the EK be a generic key and then derive individual AES keys from it via an HKDF Expand step before encrypting the actual data. Signed-off-by: Simo Sorce <[email protected]>
No need for object gimmicks, just keep a copy of the struct and remove a bunch of now useless attributes. Signed-off-by: Simo Sorce <[email protected]>
Insted of using a complex pkcs#11 object, save user PIN and counters in the metadata table. Enhance the ACI Authentication Info structure to carry all of the user data and streamline all related operations. Signed-off-by: Simo Sorce <[email protected]>
Change these two databases to properly handle the move of token and user info out of the database objects space. Signed-off-by: Simo Sorce <[email protected]>
|
Rebased on main, and fixed the typo in the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metadata to the sqlite database that allows for easier crypto agility as well as allow future upgrades. Move all non-object information to a metadata table.
Fixes #109