Refactor and Centralize ECC helpers #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
keyspecific
branch
3 times, most recently
from
9eef515 to
6ce3d85
Compare
This allows to map errors when we want to return a generic failure instead of a specific code. Signed-off-by: Simo Sorce <[email protected]>
Change how EvpPkeys are obtained from Objects via helper methods on the EvpPkey object itself, as this looks like a more natural interface. It also unifies how this is done across all the Asymmetric Key algorithms so that the code looks more uniform. Signed-off-by: Simo Sorce <[email protected]>
All of the generic ECC properiets handling, like OIDs, OSSL Names, sizes can be managd in a single place as it does not depend on ossl specific fucntions. This allows to simplify and handle these conversions uniformly across all ECC operations and key types. Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
Also fixes feature detection to be more straightforward Signed-off-by: Simo Sorce <[email protected]>
The 'default' features are always enabled regardless of which build features are requested, forcing ugly cfg statement to exclude specific features when incompatible ones are selected, like "fips". Instead of always compiling all mechanisms by default, introduce a "standard" features that replaces the old "default". Change packaging and CI to use "standard" everywhere we implied the use the "default" feature set before. Signed-off-by: Simo Sorce <[email protected]>
simo5
changed the title
Jakuje
approved these changes
Nov 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the various ECC files to use common routines to simplify and make uniform, as much as possible all ECC helper code.
Fixes #112