Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EC_MONTGOMERY keys #111

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add support for EC_MONTGOMERY keys #111

merged 1 commit into from
Nov 19, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Nov 7, 2024

This refactors the ECDH out of the generic ECC module, as the same code is used also for derivation operation with Montgomery EC keys.

@Jakuje Jakuje force-pushed the xeddsa branch 2 times, most recently from 80a8020 to 0b31dd3 Compare November 7, 2024 20:08
@Jakuje Jakuje requested a review from simo5 November 7, 2024 20:09
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, mostly we need to improve code organization to be conformant to the style used elsewhere and ensure abstraction and type checking are maintained.

src/ec_montgomery.rs Outdated Show resolved Hide resolved
src/ossl/ecdh.rs Outdated Show resolved Hide resolved
src/ossl/ecdh.rs Outdated Show resolved Hide resolved
src/ossl/ecdh.rs Outdated Show resolved Hide resolved
This refactors the ECDH out of the generic ECC module, as the same
code is used also for derivation operation with Montgomery EC keys.

Signed-off-by: Jakub Jelen <[email protected]>
@simo5 simo5 merged commit 58d0b6e into latchset:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants