Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo ; Prefix all logging messages with "kdcproxy:" #62

Closed
wants to merge 2 commits into from

Conversation

fcami
Copy link

@fcami fcami commented Mar 22, 2024

  • Fix typo (Conection)

  • Prefix all logging messages with "kdcproxy:"

    When running kdcproxy in mod_wsgi, it is unclear from which
    component error messages come from. For example:

    mod_wsgi.c(): [client WARNING:root:Connection broken while writing (...)

fcami added 2 commits March 22, 2024 09:21
Signed-off-by: François Cami <[email protected]>
When running kdcproxy in mod_wsgi, it is unclear from which
component error messages come from. For example:

mod_wsgi.c(): [client WARNING:root:Connection broken while writing (...)

Prefixing all logging messages with "kdcproxy:" solves this.

Signed-off-by: François Cami <[email protected]>
@simo5
Copy link
Member

simo5 commented Mar 22, 2024

Any reason why you have no simply created a new logger on the class like:
self.logger = logging.getLogger('kdcproxy') and then changeed the calls to use self.logger instead of logging directly ?

@fcami
Copy link
Author

fcami commented Mar 22, 2024

That would have been cleaner indeed.

@fcami fcami closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants