-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace deprecated package with typing_extensions #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks
Would you mind adding a sign-off-by line in your commit? |
Signed-off-by: David Diamant <[email protected]>
is this ok? |
Perfect, thank you |
Great fix! Any plans for a new version on pypi? |
I was not planning a release just yet, is this something that would warrant a 1.5.2 on its own ? |
It fixes a bug that stops the PyCharm debugger from working (GrahamDumpleton/wrapt#257) so it would help us a lot! |
We have also IntelliJ IDEA debugger problems. A new release would be greatly appreciated :-) |
Hi team — wondering if anyone checked in 3.6 whether this was working for them? I know that 3.6 is well beyond EOL but we still support it and our builds started breaking a few hours ago when jwcrypto 1.5.2 was released. Seems from intial tracking that its from the import change. I can reproduce in 3.6.15:
Curious if this was considered or if we should simply pin to |
I did consider it briefly, but 3.6 was deprecated for a while and removed from CI here: 4f6cf30 |
Fair enough @simo5 — would it then be possible to update https://github.com/latchset/jwcrypto/blob/main/setup.py#L43? |
I guess that would only be worthwhile if 1.5.2 was yanked first... Not sure if you're willing to do that |
Upstream python 3.6 support was over 2 years ago even for security: https://endoflife.date/python |
Would you mind opening an issue about this so I do not forget? |
fixes #338