Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated package with typing_extensions #337

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

david-homelend
Copy link
Contributor

@david-homelend david-homelend commented Jan 4, 2024

fixes #338

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@simo5
Copy link
Member

simo5 commented Jan 8, 2024

Would you mind adding a sign-off-by line in your commit?

@david-homelend
Copy link
Contributor Author

is this ok?

@simo5
Copy link
Member

simo5 commented Jan 8, 2024

Perfect, thank you

@simo5 simo5 merged commit 70c0782 into latchset:main Jan 8, 2024
13 checks passed
@rvdrijst
Copy link

rvdrijst commented Feb 6, 2024

Great fix! Any plans for a new version on pypi?

@simo5
Copy link
Member

simo5 commented Feb 6, 2024

I was not planning a release just yet, is this something that would warrant a 1.5.2 on its own ?

@rvdrijst
Copy link

rvdrijst commented Feb 6, 2024

It fixes a bug that stops the PyCharm debugger from working (GrahamDumpleton/wrapt#257) so it would help us a lot!

@christianplatta1012
Copy link

We have also IntelliJ IDEA debugger problems. A new release would be greatly appreciated :-)

@simo5
Copy link
Member

simo5 commented Feb 7, 2024

https://github.com/latchset/jwcrypto/releases/tag/v1.5.2

@bobleckelibm
Copy link

bobleckelibm commented Feb 7, 2024

Hi team — wondering if anyone checked in 3.6 whether this was working for them? I know that 3.6 is well beyond EOL but we still support it and our builds started breaking a few hours ago when jwcrypto 1.5.2 was released. Seems from intial tracking that its from the import change. I can reproduce in 3.6.15:

$ python
Python 3.6.15 (default, Oct 17 2023, 13:49:36)
[GCC Apple LLVM 15.0.0 (clang-1500.0.40.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from typing_extensions import deprecated
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'deprecated'

Curious if this was considered or if we should simply pin to <1.5.2

@simo5
Copy link
Member

simo5 commented Feb 7, 2024

I did consider it briefly, but 3.6 was deprecated for a while and removed from CI here: 4f6cf30

@bobleckelibm
Copy link

Fair enough @simo5 — would it then be possible to update https://github.com/latchset/jwcrypto/blob/main/setup.py#L43?

@bobleckelibm
Copy link

I guess that would only be worthwhile if 1.5.2 was yanked first... Not sure if you're willing to do that

@simo5
Copy link
Member

simo5 commented Feb 7, 2024

Upstream python 3.6 support was over 2 years ago even for security: https://endoflife.date/python

@simo5
Copy link
Member

simo5 commented Feb 7, 2024

Fair enough @simo5 — would it then be possible to update https://github.com/latchset/jwcrypto/blob/main/setup.py#L43?

Would you mind opening an issue about this so I do not forget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: wrapper has not been initialized in jwcrypto Library
5 participants