-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement elementary .pem
keyfile parsing.
#62
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,12 @@ static const jcmd_doc_t jcmd_doc_key[] = { | |
{} | ||
}; | ||
|
||
static const jcmd_doc_t jcmd_doc_pem[] = { | ||
{ .arg = "FILE", .doc="Import JWK from '.PEM' FILE" }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it required for the file to be ".PEM"? Why not just "Import JWK from FILE"? |
||
{ .arg = "-", .doc="Import JWK from '.PEM' on standard input" }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think "Import JWK from standard input" fits better |
||
{} | ||
}; | ||
|
||
void | ||
jcmd_push(jcmd_t *cmd); | ||
|
||
|
@@ -98,6 +104,7 @@ jcmd_set_t jcmd_opt_set_jsons; /* Takes json_t** */ | |
jcmd_set_t jcmd_opt_set_json; /* Takes json_t** */ | ||
jcmd_set_t jcmd_opt_set_jwkt; /* Takes json_t** */ | ||
jcmd_set_t jcmd_opt_set_jwks; /* Takes json_t** */ | ||
jcmd_set_t jcmd_opt_set_pem; /* Takes json_t** */ | ||
jcmd_set_t jcmd_opt_set_flag; /* Takes bool* */ | ||
|
||
void | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, it is not distinguished the case of !file vs the case of PEM_read_PrivateKey.
Distinguish between them, so that if the error has to do with PEM_read_PrivateKey, then fclose on file is done