Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--version-script
is not supported on macOS ld while-export-symbols-regex
seems to be specific to libtool. Previous macOS ld may have skipped this but Xcode 16 fails:macOS instead has:
-exported_symbol <symbol>
-exported_symbols_list <filename>
Could alternatively use
-exported_symbols_list
and hardcode every name similar tolibjose.map
, but there is a good chance of it going out-of-sync without proper checks as it needs a different file with a flat list of symbols/patternsMay want to consider using visibility attributes instead which should allow better cross-compatibility.
The build failure was seen in Homebrew when trying to build
jose
on Sequoia (Xcode 16, based on LLVM 17).Taking a look at binaries built from older Xcode, the flags were most likely never used, e.g.
Doing a build with
-exported_symbol