Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meson changes #135

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Meson changes #135

merged 3 commits into from
Feb 1, 2024

Conversation

hdholm
Copy link
Contributor

@hdholm hdholm commented Jun 2, 2023

Two small changes to improve how meson works

  • Add "setup" to meson build to eliminate some meson warnings
  • Use the library object jansson instead of the string in the pkg_config configuration. This results in pkg_config actually knowing that there was a minimum version specified.

sarroutbi
sarroutbi approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for the PR

@sarroutbi sarroutbi requested a review from sergio-correia June 5, 2023 14:41
@sarroutbi sarroutbi merged commit c1569b7 into latchset:master Feb 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-correia sergio-correia sergio-correia approved these changes

@sarroutbi sarroutbi sarroutbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdholm @sarroutbi @sergio-correia