[wip] luks: get rid of bashisms in clevis-luks-common-functions #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in latchset#202, let's try to define some sort of style guide to try to improve portability and consistency across the scripts. The suggestions include: - getting rid of bashisms, at least for scripts running in early userland - running with "set -e" and "set -u" - using $() instead of backticks - using long form of `jose' commands, for better readability This commit converts clevis-luks-common-function and its user clevis-luks-list. As of now, shellcheck complains of the following: "SC2039: In POSIX sh, 'local' is undefined." This can be muted with `shellcheck -eSC2039'
sergio-correia
changed the title
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #202, let's try to define some sort of style guide
to try to improve portability and consistency across the scripts.
The suggestions include:
userland
This commit converts clevis-luks-common-function and its user
clevis-luks-list.
As of now, shellcheck complains of the following:
"SC2039: In POSIX sh, 'local' is undefined."
This can be muted with `shellcheck -eSC2039'