Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp rewrite 1st draft #274

Merged
merged 6 commits into from
May 26, 2023
Merged

cp rewrite 1st draft #274

merged 6 commits into from
May 26, 2023

Conversation

ayushkamat
Copy link
Contributor

No description provided.

ayushkamat added 2 commits May 24, 2023 20:38
@ayushkamat
initial cp
a854a5c 
Signed-off-by: Ayush Kamat <[email protected]>
@ayushkamat
smol fixies
d76e051 
Signed-off-by: Ayush Kamat <[email protected]>
AidanAbd
AidanAbd reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@AidanAbd AidanAbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some random stuff to start

latch_cli/constants.py Show resolved Hide resolved
latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/services/cp/cp.py Outdated Show resolved Hide resolved
latch_cli/services/cp/utils.py Outdated Show resolved Hide resolved
latch_cli/services/cp/utils.py Outdated Show resolved Hide resolved
latch_cli/services/cp/utils.py Show resolved Hide resolved
@ayushkamat
pr comments
b6812a2 
Signed-off-by: Ayush Kamat <[email protected]>
maximsmol
maximsmol requested changes May 25, 2023
View reviewed changes
Copy link
Member

@maximsmol maximsmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank god __init__ is now empty

pass 1

latch_cli/config/latch.py Show resolved Hide resolved
latch_cli/config/latch.py Show resolved Hide resolved
latch_cli/config/latch.py Show resolved Hide resolved
latch_cli/constants.py Show resolved Hide resolved
latch_cli/constants.py Outdated Show resolved Hide resolved
latch_cli/services/cp/utils.py Outdated Show resolved Hide resolved
latch_cli/services/cp/utils.py Outdated Show resolved Hide resolved
latch_cli/tinyrequests.py Show resolved Hide resolved
latch_cli/tinyrequests.py Show resolved Hide resolved
latch_cli/tinyrequests.py Show resolved Hide resolved
AidanAbd
AidanAbd reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@AidanAbd AidanAbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more stuff

latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/ldata_utils.py Show resolved Hide resolved
latch_cli/services/cp/upload.py Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
maximsmol
maximsmol requested changes May 25, 2023
View reviewed changes
Copy link
Member

@maximsmol maximsmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally we need to redo error handling to not raise exceptions because then all you get is the generic exception crash dialog

second pass

latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/download.py Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/services/cp/progress.py Outdated Show resolved Hide resolved
latch_cli/services/cp/progress.py Outdated Show resolved Hide resolved
latch_cli/services/cp/progress.py Outdated Show resolved Hide resolved
latch_cli/services/cp/progress.py Outdated Show resolved Hide resolved
latch_cli/services/cp/progress.py Show resolved Hide resolved
maximsmol
maximsmol requested changes May 25, 2023
View reviewed changes
latch_cli/services/cp/upload.py Show resolved Hide resolved
latch_cli/services/cp/upload.py Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Outdated Show resolved Hide resolved
ayushkamat added 2 commits May 26, 2023 13:09
@ayushkamat
fix comments + clean up imports
b85841c 
Signed-off-by: Ayush Kamat <[email protected]>
@ayushkamat
small fix
9dafc66 
Signed-off-by: Ayush Kamat <[email protected]>
AidanAbd
AidanAbd approved these changes May 26, 2023
View reviewed changes
latch_cli/services/cp/download.py Show resolved Hide resolved
latch_cli/services/cp/download.py Show resolved Hide resolved
latch_cli/services/cp/download.py Outdated Show resolved Hide resolved
latch_cli/config/user.py Show resolved Hide resolved
maximsmol
maximsmol requested changes May 26, 2023
View reviewed changes
Copy link
Member

@maximsmol maximsmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a thing

latch_cli/config/user.py Outdated Show resolved Hide resolved
latch_cli/config/user.py Outdated Show resolved Hide resolved
latch_cli/config/user.py Show resolved Hide resolved
latch_cli/constants.py Outdated Show resolved Hide resolved
latch_cli/main.py Outdated Show resolved Hide resolved
latch_cli/services/cp/path_utils.py Outdated Show resolved Hide resolved
latch_cli/services/cp/path_utils.py Outdated Show resolved Hide resolved
latch_cli/services/cp/path_utils.py Outdated Show resolved Hide resolved
latch_cli/services/cp/progress.py Outdated Show resolved Hide resolved
latch_cli/services/cp/upload.py Show resolved Hide resolved
@ayushkamat
comments
4eaed70 
Signed-off-by: Ayush Kamat <[email protected]>
@ayushkamat ayushkamat merged commit 778734e into main May 26, 2023
@ayushkamat ayushkamat deleted the ayush/rewrite-cp branch May 26, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximsmol maximsmol maximsmol requested changes

@AidanAbd AidanAbd AidanAbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushkamat @maximsmol @AidanAbd