Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

Support for linux-amd64, linux-arm and linux-arm64 added #18

Open
wants to merge 84 commits into
base: master
Choose a base branch
from

Conversation

RaymondMouthaan
Copy link

Added support for multiple architectures: linux-amd64, linux-arm and linux-arm64.
Added support for docker manifest tool (no need for explicit architecture tagging).
Update readme and docker-compose yml.
Based upon Travis CI, to build and push the images to docker hub.

Howto:

  • Create an account on https://travis-ci.org
  • Connect you GitHub to https://travis-ci.org
  • Sync your GitHub projects with travis
  • Enable docker-image-logitech-media-server project in travis
  • Add environment variables to docker-image-logitech-media-server
    • DOCKER_USER = larsks
    • DOCKER_PASS = <your_docker_hub_password>
  • Changes to docker-image-logitech-media-server in github triggers travis to start a build, but only when a release is made, the images are getting pushed to docker hub

Don't hesitate to contact me if you have questions.

Regards,
Ray

@MarkJonas
Copy link

@RaymondMouthaan
I did something similar you did. My pull request is also pending since some months.

Meanwhile I forked the project on GitLab: https://gitlab.com/toertel/docker-image-logitech-media-server

The fork supports amd64 (PC), arm32v7 (Raspberry Pi 2/3/4), and arm64v8. Additionally, images are built automatically using GitLab CI. Releases are pushed to Docker Hub.

It would be great hearing from you. :)

@RaymondMouthaan
Copy link
Author

RaymondMouthaan commented Jan 6, 2020

@MarkJonas

Sound like pretty much the same ;-)
I stopped 18 months ago, since it seems the PR never gets merged. It's a good thing you created the docker images yourself. I will probably use them and give my Logitech Squeezebox a second life :-).

If I may suggest for your images: manifest them so that docker automatically pulls the right image for the appropriate architecture. This way one doesn't need to specify an explicit tag when an image gets pulled.

For example: assume you manifest the latest versions of arm32v6, arm32v7, arm64v8 and amd64 to tag latest. Then when toertel / logitech-media-server:latest gets pulled, Docker auto detects which architecture its running on and pulls the corresponding image for it. In case of Docker Swarm and Kubernetes with nodes of different architectures this becomes very handy and flexible.

An good example project is Node-RED Docker

If you need any help, don't hesitate to contact.

Regards & keep up the good work!
Ray

@SuperQ
Copy link

SuperQ commented Jan 20, 2020

Yes, using manifests is also how we publish multi-arch images for our projects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants