added @warning, clearer warning msg

larsacus · Jul 1, 2013 · 2dc4478 · 2dc4478
1 parent 2e95cc8
commit 2dc4478
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/PlaceKit/UIImageView+PlaceKit.h b/PlaceKit/UIImageView+PlaceKit.h
@@ -43,6 +43,7 @@
 /** Place a random image in a specific category with a given size from lorempixel.com
  
  @param size The size in points of your random image
+ @warning Image size will be clamped to max size supported by service
  @param category The category that you would like your image to be chosen from. A full list of valid categories can be found at http://lorempixel.com
  */
 - (void)placeRandomImageWithSize:(CGSize)size
@@ -51,6 +52,7 @@
 /** Place a random greyscale image in a specific category with a given size from lorempixel.com
  
  @param size The size in points of your random greyscale image
+ @warning Image size will be clamped to max size supported by service
  @param category The category that you would like your image to be chosen from. A full list of valid categories can be found at http://lorempixel.com
  */
 - (void)placeRandomGreyscaleImageWithSize:(CGSize)size
@@ -59,12 +61,14 @@
 /** Place a random image with a given size from lorempixel.com
  
  @param size The size in points of your random image
+ @warning Image size will be clamped to max size supported by service
  */
 - (void)placeRandomImageWithSize:(CGSize)size;
 
 /** Place a random greyscale image with a given size from lorempixel.com
  
  @param size The size in points of your random greyscale image
+ @warning Image size will be clamped to max size supported by service
  */
 - (void)placeRandomGreyscaleImageWithSize:(CGSize)size;
 
@@ -89,20 +93,24 @@
 /** Place a random image in a specific category with an inherited size from lorempixel.com
  
  @param category The category that you would like your image to be chosen from. A full list of valid categories can be found at http://lorempixel.com
+ @warning Image size will be clamped to max size supported by service
  */
 - (void)placeRandomImageFromCategory:(NSString *)category;
 
 /** Place a random greyscale image in a specific category with an inherited size from lorempixel.com
  
  @param category The category that you would like your image to be chosen from. A full list of valid categories can be found at http://lorempixel.com
+ @warning Image size will be clamped to max size supported by service
  */
 - (void)placeRandomGreyscaleImageFromCategory:(NSString *)category;
 
 /** Place a random image with an inherited size from lorempixel.com
+ @warning Image size will be clamped to max size supported by service
  */
 - (void)placeRandomImage;
 
 /** Place a random greyscale image with an inherited size from lorempixel.com
+ @warning Image size will be clamped to max size supported by service
  */
 - (void)placeRandomGreyscaleImage;
 

diff --git a/PlaceKit/UIImageView+PlaceKit.m b/PlaceKit/UIImageView+PlaceKit.m
@@ -82,12 +82,13 @@ - (void)placeImageWithURLString:(NSString *)path size:(CGSize)size{
     CGFloat screenScale = [[UIScreen mainScreen] scale];
     CGFloat w = size.width*screenScale;
     CGFloat h = size.height*screenScale;
-    if ([path rangeOfString:@"lorempixel.com"].length > 0) {
+    NSString *service = @"lorempixel.com";
+    if ([path rangeOfString:service].length > 0) {
         CGFloat max = 1920.0f;
         if (w > max || h > max) {
           w = MIN(w,max);
           h = MIN(h,max);
-          NSLog(@"%s: Warn: requested image size > max. using %.0fx%.0f", __PRETTY_FUNCTION__, w, h);
+          NSLog(@"%s: Warn: clamping image size to %@ max size. using %.0fx%.0f", __PRETTY_FUNCTION__, service, w, h);
         }
     }
     NSString *urlString = [NSString stringWithFormat:path, w, h];