Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added normalizePath #26

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

McGern
Copy link
Contributor

@McGern McGern commented Sep 18, 2024

Added normalizePath method from vite so the import part for the templates work on windows machines. Changes e.g. c:\path\to\file.twig => c:/path/to/file.twig

Issue: #24

Added normalizePath method from vite so the import part for the templates work on windows machines. Changes e.g. c:\path\to\file.twig => c:/path/to/file.twig
@McGern
Copy link
Contributor Author

McGern commented Sep 18, 2024

@larowlan Just a wee PR to add the normalizePath method to the resolveFile method.

Sorry, I don't know how to properly link the PR to the ticket, so I just added the link to the PR comment.

@larowlan
Copy link
Owner

Made a minor change, as I prefer early returns. If it passes tests happy to ship this

@larowlan larowlan merged commit ed6a9d6 into larowlan:main Sep 18, 2024
5 checks passed
Copy link

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants