Tighten up timeouts

laravel · Aug 30, 2023 · e74de63 · e74de63
1 parent cd9678b
commit e74de63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/Feature/RedisTest.php b/tests/Feature/RedisTest.php
@@ -9,7 +9,7 @@
 use Laravel\Pulse\Entries\Entry;
 use Laravel\Pulse\Ingests\Redis;
 
-beforeEach(fn () => Process::timeout(5)->run('redis-cli DEL laravel_database_laravel:pulse:entries')->throw());
+beforeEach(fn () => Process::timeout(1)->run('redis-cli DEL laravel_database_laravel:pulse:entries')->throw());
 
 it('runs the same commands while ingesting entries', function ($driver) {
     Config::set('database.redis.client', $driver);
@@ -42,12 +42,12 @@
         ->run('redis-cli XINFO STREAM laravel_database_laravel:pulse:entries')
         ->throw()
         ->output();
-    [$firstKey, $lastKey] = collect(explode("\n", $output))->only([17, 21])->values();
+    [$firstEntryKey, $lastEntryKey] = collect(explode("\n", $output))->only([17, 21])->values();
 
     $commands = captureRedisCommands(fn () => $ingest->store(new NullStorage, 567));
 
     expect($commands)->toContain('"XRANGE" "laravel_database_laravel:pulse:entries" "-" "+" "COUNT" "567"');
-    expect($commands)->toContain('"XDEL" "laravel_database_laravel:pulse:entries" "'.$firstKey.'" "'.$lastKey.'"');
+    expect($commands)->toContain('"XDEL" "laravel_database_laravel:pulse:entries" "'.$firstEntryKey.'" "'.$lastEntryKey.'"');
 })->with(['predis', 'phpredis']);
 
 class NullStorage implements Storage

diff --git a/tests/Pest.php b/tests/Pest.php
@@ -74,7 +74,7 @@ function captureRedisCommands(callable $callback)
     Sleep::for(50)->milliseconds();
 
     $pingFlag = Str::random();
-    Process::timeout(10)->run("redis-cli ping {$pingFlag}")->throw();
+    Process::timeout(1)->run("redis-cli ping {$pingFlag}")->throw();
 
     $pingedAt = new CarbonImmutable;