Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced installation adding configurable database conncetion prompts #326

Closed
wants to merge 2 commits into from

Conversation

yourchocomate
Copy link

@yourchocomate yourchocomate commented Mar 18, 2024

Problem: Fresh installation of laravel using any database driver rather than sqlite starts with an error of can't connect with database. (more information ar #324)

Description:
This PR is supposed to make laravel installation smoother and more user-friendly by removing unnecessary migration prompt when database connection is not specified for drivers rather than mysql.

laravel-installer-windows

**Here's a video comparing current installer and patched installer experience **

  • windows
0318.mp4
  • Linux
laravel-installer-linux.mp4

Also,
The migration prompt won't appear when database connection is not specified.

Changes Made:

  • Added new promptForDatabaseConfig function to specify the database connection.
  • The prompt is made compatible with command option such as --database=pgsql
  • promptForDatabaseOptions now returns three array values including configuration array
  • Moved Default connection information array from commentDatabaseConfigurationForSqlite to configureDefaultDatabaseConnection

Any feedback & suggestions will be appreciated. Thank You.

@yourchocomate yourchocomate marked this pull request as draft March 18, 2024 10:51
@driesvints driesvints changed the title [5.6.x] Enhanced installation adding configurable database conncetion prompts Enhanced installation adding configurable database conncetion prompts Mar 18, 2024
@yourchocomate yourchocomate marked this pull request as ready for review March 18, 2024 10:54
@driesvints driesvints requested a review from nunomaduro March 18, 2024 15:01
@yourchocomate
Copy link
Author

@taylorotwell
Any feedback would be appreciated for future approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants