Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HasUuids trait when Model has id uuid primary. #655

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

rcrosbourne
Copy link
Contributor

Addresses issue #646

@jasonmccreary
Copy link
Collaborator

Thanks for this. While the build is passing, you need to lint the code. You may do so by running vendor/bin/pint, then submit your changes.

There are some other refactors I would make, but if you can lint your code, I'll do the rest.

@rcrosbourne
Copy link
Contributor Author

Hey J Mac,

I ran the linter. The code now conforms to the standard.

@brocard
Copy link

brocard commented Dec 6, 2023

thanks @rcrosbourne

@jasonmccreary
Copy link
Collaborator

I cleaned up a few things, but there's more I'd like to fix. The functionality and test is there. So that's good enough to merge. I'll do the rest on master before merging.

@jasonmccreary jasonmccreary merged commit 747240a into laravel-shift:master Dec 6, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants