Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StatementGenerator #310

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Fix StatementGenerator #310

merged 2 commits into from
Jul 24, 2020

Conversation

bingtsingw
Copy link
Contributor

I like this feature #164, but instead of committing 100 files at once, I'll split it into several pull requests, every time with simple change.

@jasonmccreary
Copy link
Collaborator

How does this allow you to publish the Job stub?

@bingtsingw
Copy link
Contributor Author

Forget about publish now, this pr is just a small refactor.
I was modifying stubs to match laravel, and find this refactor can submit independently

@jasonmccreary
Copy link
Collaborator

Alrighty.

@jasonmccreary jasonmccreary merged commit 0e93ed4 into laravel-shift:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bingtsingw @jasonmccreary