event pass through #667
Merged
event pass through #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to do it via something similar to |
|
What about an enum: Block, Passthrough, None? |
|
I also wasn't prefectly sure on the naming. pointer-events:none is what it is on the web so it might just be good to use that since it will be common/discoverable as the name |
|
Yeah following with the web's name would be fine since we already have done lots of that. |
|
Hmm. I'll skip on the enum for now. just the two states covers all current use cases so I'll just do that |
jrmoulton
force-pushed
the
event-passthrough
branch
from
ce49cdb to
7e214c1
Compare
jrmoulton
force-pushed
the
event-passthrough
branch
from
7e214c1 to
09381de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that you can configure events to be allowed to be passed to overlapping siblings. This is necessary for the widget gallery that creates highlight overlays over items.
This also fixes #665