don't change focus to on_click under other on_click

[jrmoulton]

@dzhou121

I've been trying to fix the issue where having an on_click handler on top of another on_click handler will move focus to the bottom one and it will receive the click event instead of the one on top.

This change fixes the issue but I'm not sure I completely understand it.

The problem comes because both views will get the pointer down and since the bottom one gets it last it gets the focus for the pointer up.

Review on this would be good

Fixes #295

[jrmoulton]

whoops. pushed to wrong branch

[dzhou121]

I feel like this is not needed because the PointerDown event propagation was stopped. Can you please test if it fixes the issue without this check?

[jrmoulton]

This is the part I don't completely understand what is happening. If I remove that check then anytime that an event returns Stop (even a different event handler such as PointerDown) the focus will be switched away on pointer down

[jrmoulton]

Figured it out. There was another issue. If a view has focus and then there is a pointer down event inside of that view (on a child) that returns EventPropagation::Stop the focus will have been cleared without giving the focus to any other view.

This checks on pointer down if the event is still inside of the old was_focused and nothing else has gained focus it gives focus back to the view that previously had focus.