Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #341
This PR does two things
EditorTextProv
as if it needs to the fullEditor
to pass to phantom text functions then it doesn't need to be a separate structureTextLayoutProvider::text
returnRope
rather than&Rope
which I'd been thinking about anyway asRope
is cheaply cloneableTextEditor
widget(I implemented this on
TextDocument
(so it can be used viaTextEditor
easily) rather than making it a generalEditor
feature asEditor
provides the general tool of phantom text to make placeholder easy, which keeps theEditor
simpler.)Of course this also gets us closer to being able to swap out the
text_input
so they use the same code.