Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ViewState.children_nodes #254

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Remove ViewState.children_nodes #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,8 +1367,6 @@ impl<'a> LayoutCx<'a> {
if has_children {
let nodes = children(self);
let _ = self.app_state.taffy.set_children(node, &nodes);
let view = self.app_state.view_state(id);
view.children_nodes = nodes;
}

node
Expand Down
2 changes: 0 additions & 2 deletions src/view_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ bitflags! {
/// View state stores internal state associated with a view which is owned and managed by Floem.
pub struct ViewState {
pub(crate) node: Node,
pub(crate) children_nodes: Vec<Node>,
pub(crate) requested_changes: ChangeFlags,
/// Layout is requested on all direct and indirect children.
pub(crate) request_style_recursive: bool,
Expand Down Expand Up @@ -164,7 +163,6 @@ impl ViewState {
combined_style: Style::new(),
taffy_style: taffy::style::Style::DEFAULT,
dragging_style: None,
children_nodes: Vec::new(),
event_listeners: HashMap::new(),
context_menu: None,
popout_menu: None,
Expand Down