Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlays and use it for tooltips #195

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add overlays and use it for tooltips #195

merged 1 commit into from
Nov 20, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 20, 2023

This adds overlays which are views which are on top of all other views in a window. They can be created using add_overlay and remove_overlay. It's intended to replace z-order for use with popups, drop down menus, tooptips, etc. as it works with events and the tiny-skia backend (and in the future, vello).

They are currently implemented using WindowView which is the new root view of a window. It contains the main application view and a number of overlays. Ideally these overlays should be their own windows, but that would require some work to avoid rendering setup for each window.

The tooltip view is changed to use these.

@dzhou121 dzhou121 merged commit b86ea50 into lapce:main Nov 20, 2023
7 checks passed
@Zoxc Zoxc deleted the overlays branch November 20, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants