Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect cleanups #174

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Effect cleanups #174

merged 1 commit into from
Nov 14, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 14, 2023

This uses HashSet<Id> instead of Option<HashSet<Id>> for observers.

The effect value no longer uses Box<Any>.

run_initial_effect is added to avoid some code on the initial effect run.

@dzhou121 dzhou121 merged commit 6faec0e into lapce:main Nov 14, 2023
7 checks passed
@Zoxc Zoxc deleted the effect-tweaks branch November 14, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants