Add defaults for View trait methods
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoxc
changed the title
View trait methodsView trait methods
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
========================================
+ Coverage 4.99% 5.20% +0.21%
========================================
Files 56 56
Lines 11328 10868 -460
========================================
Hits 566 566
+ Misses 10762 10302 -460
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
dzhou121
reviewed
Nov 5, 2023
| fn event(&mut self, cx: &mut EventCx, id_path: Option<&[Id]>, event: Event) -> bool { | ||
| let mut handled = false; | ||
| self.for_each_child_mut(&mut |child| { | ||
| handled |= cx.view_event(child, id_path, event.clone()); |
There was a problem hiding this comment.
We'll probably need to break out if the event is handled.
There was a problem hiding this comment.
Returning true breaks the loop here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds default methods to the
Viewtrait which generally work with views with or without children. This is quite helpful in reducing code duplication across view impls. It also serves as a reference for new view implementations.for_each_childandfor_each_child_mutare added toViewto iterate over children without allocation. Thechildrenandchildren_mutmethods can probably be removed, but I haven't looked carefully at their uses yet.